Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the LangChain integration #15229

Merged
merged 10 commits into from
Jul 21, 2023
Merged

Add the LangChain integration #15229

merged 10 commits into from
Jul 21, 2023

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Jul 10, 2023 •
edited
Loading

What does this PR do?

Adds the LangChain integration, along with corresponding dashboard.
Additionally, this PR adds the apm-core-python and llm-obs teams as codeowners for the OpenAI/LangChain integrations.

Motivation

The LangChain APM integration (ref) adds tracing support for the Python LangChain library, along with metrics and logging for prompt-completions.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@Yun-Kim Yun-Kim requested review from a team as code owners July 10, 2023 19:11
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

FlorentClarret
FlorentClarret requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 I had a quick first look and left some comments. Let us know if you need help to deploy your tile and sync the assets into staging/prod 🙂

.github/CODEOWNERS Outdated Show resolved Hide resolved
langchain/images/IMAGES_README.md Outdated Show resolved Hide resolved
langchain/manifest.json Outdated Show resolved Hide resolved
langchain/README.md Outdated Show resolved Hide resolved
langchain/metadata.csv Outdated Show resolved Hide resolved
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

FlorentClarret
FlorentClarret reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one more comment!

Also the tile is available on staging

langchain/README.md Outdated Show resolved Hide resolved
@Yun-Kim
Copy link
Contributor Author

Yun-Kim commented Jul 20, 2023

Hi @FlorentClarret, could we get this merged? Thank you very much!

@yzhan289 yzhan289 merged commit 7a8c473 into master Jul 21, 2023
28 of 29 checks passed
@yzhan289 yzhan289 deleted the yunkim/langchain branch July 21, 2023 13:14
@vivek-datadog vivek-datadog mentioned this pull request Aug 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

@FlorentClarret FlorentClarret Awaiting requested review from FlorentClarret

Assignees
No one assigned
Labels
dev/testing dev/tooling documentation editorial review Waiting on a more in-depth review from a docs team editor integration/langchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yun-Kim @FlorentClarret @yzhan289