Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Containerd metadata.csv for metrics that were removed in 7.35 #15276

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Update Containerd metadata.csv for metrics that were removed in 7.35 #15276

merged 1 commit into from
Jul 17, 2023

Conversation

kaitlavs
Copy link
Contributor

@kaitlavs kaitlavs commented Jul 13, 2023 •
edited
Loading

What does this PR do?

This PR: 10383 removed a handful of containerd metrics from being reported by the containerd check. This updates the metadata.csv so the documentation is up to date

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@kaitlavs
Update Containerd metadata.csv for metrics that were removed in 7.35
b6743b6 
The following PR removed a handful of containerd metrics: DataDog/datadog-agent#10383. This updates the metadata.csv so the documentation is up-to-date
@kaitlavs kaitlavs added changelog/no-changelog integration/containerd qa/skip-qa Automatically skip this PR for the next QA labels Jul 13, 2023
@kaitlavs kaitlavs requested review from a team as code owners July 13, 2023 19:49
@FlorentClarret FlorentClarret merged commit 0b1f6df into master Jul 17, 2023
30 checks passed
@FlorentClarret FlorentClarret deleted the kaitlavs-patch-1 branch July 17, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidor davidor davidor approved these changes

@FlorentClarret FlorentClarret FlorentClarret approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/containerd qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlavs @davidor @FlorentClarret