Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardware metrics for Fortinet (non-categorical) #15553

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

lizaerem
Copy link
Contributor

What does this PR do?

See title

Motivation

NDM-2304

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #15553 (3d5e4c9) into master (eb7b58f) will decrease coverage by 0.06%.
The diff coverage is 11.49%.

Flag Coverage Δ
snmp 48.97% <11.49%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Test Results

       6 files      6 suites   28m 37s ⏱️
   397 tests 397 ✔️        0 💤 0
1 845 runs  577 ✔️ 1 268 💤 0

Results for commit 3d5e4c9.

♻️ This comment has been updated with latest results.

@lizaerem lizaerem requested review from a team as code owners August 16, 2023 08:48
@lizaerem lizaerem force-pushed the lizaerem/ndm-snmp-hardware-metrics-fortinet branch from 9bd1db7 to f541f37 Compare August 16, 2023 08:57
@lizaerem lizaerem marked this pull request as draft August 16, 2023 08:58
@NouhaManai96 NouhaManai96 removed request for a team August 16, 2023 09:18
@ghost ghost added the documentation label Aug 16, 2023
@lizaerem lizaerem marked this pull request as ready for review August 16, 2023 10:03
NouhaManai96
NouhaManai96 previously approved these changes Aug 17, 2023
@lizaerem lizaerem merged commit 44fb344 into master Aug 17, 2023
27 checks passed
@lizaerem lizaerem deleted the lizaerem/ndm-snmp-hardware-metrics-fortinet branch August 17, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants