Add Windows service trigger_start filter to config
#15975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
clarkb7
reviewed
Oct 7, 2023
aliciascott
previously approved these changes
Oct 10, 2023
iglendd
previously approved these changes
Oct 10, 2023
steveny91
reviewed
Oct 10, 2023
Comment on lines
42
to
43
| - startup_type: automatic | ||
| trigger_start: false |
There was a problem hiding this comment.
startup_type and trigger_start
Are these two params used exclusively together? Or can either of them be a standalone param?
There was a problem hiding this comment.
Hi @steveny91, startup_type and trigger_start can be used standalone they don't need to be used together.
There was a problem hiding this comment.
Then shouldn't the config example have:
Suggested change
| - startup_type: automatic | |
| trigger_start: false | |
| - startup_type: automatic | |
| - trigger_start: false |
Since they're standalone?
There was a problem hiding this comment.
Hey @steveny91 , Yeah that makes sense. I've added this in my latest commit.
edited README Co-authored-by: Branden Clark <[email protected]>
mrafi97
force-pushed
the
mohammad.rafi/windows-service-trigger
branch
from
7569a1e
to
afcb544
Compare
ghost
added
dev/tooling
integration/kafka_consumer
integration/kubernetes
integration/mysql
integration/pgbouncer
integration/postgres
integration/rabbitmq
integration/snmp
integration/sqlserver
integration/kube_scheduler
integration/win32_event_log
integration/kube_apiserver_metrics
integration/mapr
dependencies
release
integration/kubernetes_state_core
dev_package
base_package
ddev
integration/strimzi
integration/torchserve
labels
|
@mrafi97 I think something wrong with the PR now. It shows 247 files changed and all approvals are gone. ... And "branch is out-of date with the base branch" |
|
@iglendd I might have to close this one and open a new one, could be that my branch is much farther behind in commits than expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
trigger_startpattern to the windows_serviceservicesconfig entry that enables users to filter services by whether or not they have triggers.This new pattern combines with the existing patterns:
Motivation
Jira: https://datadoghq.atlassian.net/browse/WINA-105
builds upon #12940 to allow service filtering based on
name,startup_typeandtrigger_startAdditional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.