Collect sqlserver deadlock data #18108

kozlovb · 2024-07-23T16:30:46Z

What does this PR do?

Adds SQLServer deadlock data collection.

Motivation

Requested by various customers (DBMON-4445).

Limitation

In the first iteration, we only support odbc driver because adodb doesn't correctly map the xml data type. I'll immediately start working on a solution, but let's not block this PR.

Test case:

import adodbapi

connection_string = "Provider=MSOLEDBSQL19;Server=localhost;UID=datadog;PWD=datadog;Use Encryption for Data=Optional;"
conn = adodbapi.connect(connection_string)
cursor = conn.cursor()
query = "SELECT CAST('<root><element>Sample Value</element></root>' AS XML) AS DummyXML;"

cursor.execute(query)

adodbapi.apibase.InternalError: Data column of Unknown ADO type=141

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Changelog entries must be created for modifications to shipped code
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

codecov · 2024-07-24T15:18:07Z

Codecov Report

Attention: Patch coverage is 86.30573% with 43 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (c14b128) to head (33ce257).
Report is 2 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
active_directory	`?`
activemq	`?`
activemq_xml	`?`
aerospike	`?`
airflow	`?`
amazon_msk	`?`
ambari	`?`
apache	`?`
appgate_sdp	`?`
arangodb	`?`
argo_rollouts	`?`
argo_workflows	`?`
argocd	`?`
aspdotnet	`?`
avi_vantage	`?`
aws_neuron	`?`
azure_iot_edge	`?`
boundary	`?`
btrfs	`?`
cacti	`?`
calico	`?`
cassandra	`?`
cassandra_nodetool	`?`
ceph	`?`
cert_manager	`?`
cilium	`?`
cisco_aci	`?`
citrix_hypervisor	`?`
clickhouse	`?`
cloud_foundry_api	`?`
cloudera	`?`
cockroachdb	`?`
consul	`?`
coredns	`?`
couch	`?`
couchbase	`?`
crio	`?`
datadog_checks_base	`?`
datadog_checks_dev	`?`
datadog_checks_downloader	`?`
datadog_cluster_agent	`?`
dcgm	`?`
ddev	`?`
directory	`?`
disk	`?`
dns_check	`?`
dotnetclr	`?`
druid	`?`
ecs_fargate	`?`
eks_fargate	`?`
elastic	`?`
envoy	`?`
esxi	`?`
etcd	`?`
exchange_server	`?`
external_dns	`?`
fluentd	`?`
fluxcd	`?`
fly_io	`?`
foundationdb	`?`
gearmand	`?`
gitlab	`?`
gitlab_runner	`?`
glusterfs	`?`
go_expvar	`?`
gunicorn	`?`
haproxy	`?`
harbor	`?`
hazelcast	`?`
hdfs_datanode	`?`
hdfs_namenode	`?`
hive	`?`
hivemq	`?`
http_check	`?`
ibm_ace	`?`
ibm_db2	`?`
ibm_i	`?`
ibm_mq	`?`
ibm_was	`?`
ignite	`?`
iis	`?`
impala	`?`
istio	`?`
jboss_wildfly	`?`
kafka	`?`
kafka_consumer	`?`
karpenter	`?`
kong	`?`
kube_apiserver_metrics	`?`
kube_controller_manager	`?`
kube_dns	`?`
kube_metrics_server	`?`
kube_proxy	`?`
kube_scheduler	`?`
kubeflow	`?`
kubelet	`?`
kubernetes_cluster_autoscaler	`?`
kubernetes_state	`?`
kubevirt_api	`?`
kubevirt_controller	`?`
kyototycoon	`?`
kyverno	`?`
lighttpd	`?`
linkerd	`?`
linux_proc_extras	`?`
mapr	`?`
mapreduce	`?`
marathon	`?`
marklogic	`?`
mcache	`?`
mesos_master	`?`
mesos_slave	`?`
mongo	`?`
mysql	`?`
nagios	`?`
network	`?`
nfsstat	`?`
nginx	`?`
nginx_ingress_controller	`?`
nvidia_triton	`?`
openldap	`?`
openmetrics	`?`
openstack	`?`
openstack_controller	`?`
pdh_check	`?`
pgbouncer	`?`
php_fpm	`?`
postfix	`?`
postgres	`?`
powerdns_recursor	`?`
presto	`?`
process	`?`
prometheus	`?`
proxysql	`?`
pulsar	`?`
rabbitmq	`?`
ray	`?`
redisdb	`?`
rethinkdb	`?`
riak	`?`
riakcs	`?`
sap_hana	`?`
scylla	`?`
silk	`?`
singlestore	`?`
snmp	`?`
snowflake	`?`
solr	`?`
sonarqube	`?`
spark	`?`
sqlserver	`89.34% <86.30%> (+9.51%)`	⬆️
squid	`?`
ssh_check	`?`
statsd	`?`
strimzi	`?`
supervisord	`?`
system_core	`?`
system_swap	`?`
tcp_check	`?`
teamcity	`?`
tekton	`?`
teleport	`?`
temporal	`?`
teradata	`?`
tibco_ems	`?`
tls	`?`
tokumx	`?`
torchserve	`?`
traefik_mesh	`?`
traffic_server	`?`
twemproxy	`?`
twistlock	`?`
varnish	`?`
vault	`?`
vertica	`?`
vllm	`?`
voltdb	`?`
vsphere	`?`
weaviate	`?`
win32_event_log	`?`
windows_performance_counters	`?`
windows_service	`?`
wmi_check	`?`
yarn	`?`
zk	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

sqlserver/datadog_checks/sqlserver/queries.py

sqlserver/datadog_checks/sqlserver/deadlocks.py

sqlserver/datadog_checks/sqlserver/activity.py

github-actions · 2024-08-21T09:37:23Z