Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ddtrace version to latest (2.10.3) #18215

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Aug 6, 2024

What does this PR do?

This PR bumps ddtrace version to latest which removes PRECALL instruction on Python versions >= 3.12:
https://github.com/DataDog/dd-trace-py/pull/9222/files

Motivation

This PR introduces Python 3.12 however, python 3.12 removes PRECALL:

gh-90690: The PRECALL instruction has been removed.

which is used by ddtrace library as noted in the following stack trace:

../../../../.local/share/hatch/env/virtual/datadog-clickhouse/KY25C-l6/py3.12-18/lib/python3.12/site-packages/ddtrace/internal/wrapping.py:401: in wrap_bytecode
    Instr("PRECALL", 3, lineno=lineno),
../../../../.local/share/hatch/env/virtual/datadog-clickhouse/KY25C-l6/py3.12-18/lib/python3.12/site-packages/bytecode/instr.py:536: in __init__
    self._set(name, arg)
../../../../.local/share/hatch/env/virtual/datadog-clickhouse/KY25C-l6/py3.12-18/lib/python3.12/site-packages/bytecode/instr.py:737: in _set
    raise ValueError(f"invalid operation name: {name}")
E   ValueError: invalid operation name: PRECALL

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

github-actions bot commented Aug 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Aug 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@Kyle-Neale Kyle-Neale marked this pull request as ready for review August 6, 2024 18:48
@Kyle-Neale Kyle-Neale requested a review from a team as a code owner August 6, 2024 18:48
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (452d3d9) to head (b12d67a).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
datadog_checks_base 89.76% <ø> (+1.14%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Aug 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@Kyle-Neale Kyle-Neale merged commit d1b4544 into master Aug 7, 2024
45 checks passed
@Kyle-Neale Kyle-Neale deleted the kyleneale/bump_ddtrace branch August 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants