Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-8740 Istio Integration Edits #18398

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented Aug 22, 2024

What does this PR do?

Updates the code snippets for the OpenMetrics latest and legacy mode configuration sections in the Istio integration doc page.

Motivation

User feedback from Hotjar

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

hestonhoffman
hestonhoffman previously approved these changes Aug 22, 2024
@alai97 alai97 merged commit 9517004 into master Aug 26, 2024
35 checks passed
@alai97 alai97 deleted the alai97/update-istio-code-examples branch August 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants