Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust labeler config and ddev tests to how pyyaml indents lists #18565

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Sep 11, 2024

What does this PR do?

  • We update the labeler config to satisfy the validation.
  • We change our tests so that they catch this next time it changes from under us.

Motivation

Prevent folks who are submitting new integrations from having to deal with indentation in their PRs.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

- We update the labeler config to satisfy the validation.
- We change our tests so that they catch this next time it changes from under us.
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (fe2c262) to head (e21c421).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
ddev 88.02% <100.00%> (+0.67%) ⬆️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@iliakur iliakur merged commit d97319c into master Sep 11, 2024
66 checks passed
@iliakur iliakur deleted the ik/update-labeler-validation branch September 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants