Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertions in test for python upgrade script #18606

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Sep 17, 2024

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@Kyle-Neale Kyle-Neale marked this pull request as ready for review September 17, 2024 20:26
@Kyle-Neale Kyle-Neale requested a review from a team as a code owner September 17, 2024 20:26
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (69cffd9) to head (4aa95f5).
Report is 4 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
ddev 88.02% <100.00%> (+0.47%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale merged commit d5250d3 into master Sep 17, 2024
58 checks passed
@Kyle-Neale Kyle-Neale deleted the ik/better-assertion branch September 17, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants