Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RethinkDB version for python 3.12 #18636

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

Kyle-Neale
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (8da9ca8) to head (fd3264a).
Report is 59 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
rethinkdb 97.93% <ø> (ø)
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale changed the title Kyleneale/bump rethinkdb py312 Bump RethinkDB version for python 3.12 Sep 20, 2024
@Kyle-Neale Kyle-Neale marked this pull request as ready for review September 20, 2024 19:17
@Kyle-Neale Kyle-Neale requested a review from a team as a code owner September 20, 2024 19:17
@Kyle-Neale Kyle-Neale merged commit 0369667 into master Sep 20, 2024
50 checks passed
@Kyle-Neale Kyle-Neale deleted the kyleneale/bump_rethinkdb_py312 branch September 20, 2024 19:45
@datadog-agent-integrations-bot
Copy link
Contributor

The backport to 7.58.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.58.x 7.58.x
# Navigate to the new working tree
cd .worktrees/backport-7.58.x
# Create a new branch
git switch --create backport-18636-to-7.58.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03696677b7af9570228bb572f973117ff0375bcd
# Push it to GitHub
git push --set-upstream origin backport-18636-to-7.58.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.58.x

Then, create a pull request where the base branch is 7.58.x and the compare/head branch is backport-18636-to-7.58.x.

@datadog-agent-integrations-bot
Copy link
Contributor

The backport to 7.57.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.57.x 7.57.x
# Navigate to the new working tree
cd .worktrees/backport-7.57.x
# Create a new branch
git switch --create backport-18636-to-7.57.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03696677b7af9570228bb572f973117ff0375bcd
# Push it to GitHub
git push --set-upstream origin backport-18636-to-7.57.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.57.x

Then, create a pull request where the base branch is 7.57.x and the compare/head branch is backport-18636-to-7.57.x.

Kyle-Neale added a commit that referenced this pull request Sep 30, 2024
* test e2e with docker build of Agent with py 3.12.6

* test rethinkdb bump

* add fix for looseversion error

* add changelog and revert agent-dev image tag

(cherry picked from commit 0369667)
Kyle-Neale added a commit that referenced this pull request Sep 30, 2024
* test e2e with docker build of Agent with py 3.12.6

* test rethinkdb bump

* add fix for looseversion error

* add changelog and revert agent-dev image tag

(cherry picked from commit 0369667)
Kyle-Neale added a commit that referenced this pull request Oct 1, 2024
* test e2e with docker build of Agent with py 3.12.6

* test rethinkdb bump

* add fix for looseversion error

* add changelog and revert agent-dev image tag

(cherry picked from commit 0369667)
@datadog-agent-integrations-bot
Copy link
Contributor

The backport to master failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-18636-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03696677b7af9570228bb572f973117ff0375bcd
# Push it to GitHub
git push --set-upstream origin backport-18636-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master

Then, create a pull request where the base branch is master and the compare/head branch is backport-18636-to-master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants