Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create dashboard for openmetrics v2 #18680

Merged
merged 8 commits into from
Oct 7, 2024
Merged

create dashboard for openmetrics v2 #18680

merged 8 commits into from
Oct 7, 2024

Conversation

Janaeq
Copy link
Contributor

@Janaeq Janaeq commented Sep 26, 2024

What does this PR do?

Create a CoreDNS dashboard for openmetrics V2 metrics

Motivation

https://datadoghq.atlassian.net/browse/AGENT-12365

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@Janaeq Janaeq requested review from a team as code owners September 26, 2024 19:34
@Janaeq
Copy link
Contributor Author

Janaeq commented Sep 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 26, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dd-devflow
Copy link

dd-devflow bot commented Sep 26, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

coredns/manifest.json Outdated Show resolved Hide resolved
@Janaeq
Copy link
Contributor Author

Janaeq commented Sep 27, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 27, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 27, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@vivek-datadog vivek-datadog dismissed HadhemiDD’s stale review October 7, 2024 11:34

The requested code changes are addressed. Dismissing to unblock merge.

@vivek-datadog vivek-datadog merged commit 3fa5466 into master Oct 7, 2024
39 of 40 checks passed
@vivek-datadog vivek-datadog deleted the janae_coredns branch October 7, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants