[SIEMINT-136] DDS: Cisco Secure Web Appliance Integration v1.0.0 #18717
+5,428
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
dev/testing
dev/tooling
release
qa/skip-qa
neko-dd
added
the
editorial review
|
Created a ticket for the Docs team to review. |
dj0well
changed the title
michaelcretzman
requested changes
Oct 3, 2024
cisco_secure_web_appliance/README.md
Outdated
Comment on lines
178
to
184
| Since Datadog expects all the logs in GMT timezone by default, if the time zone of your Cisco Secure Web Appliance logs is other than GMT, please change it to GMT. Here are the steps: | ||
| 1. Go to System Administration->Time Zone. | ||
| 2. Click on `Edit Settings`. | ||
| 3. Select GMT Offset as the region. | ||
| 4. Select GMT as the Country. | ||
| 5. Select GMT (GMT) as the time zone. | ||
| 6. Submit and commit the changes. |
There was a problem hiding this comment.
Suggested change
| Since Datadog expects all the logs in GMT timezone by default, if the time zone of your Cisco Secure Web Appliance logs is other than GMT, please change it to GMT. Here are the steps: | |
| 1. Go to System Administration->Time Zone. | |
| 2. Click on `Edit Settings`. | |
| 3. Select GMT Offset as the region. | |
| 4. Select GMT as the Country. | |
| 5. Select GMT (GMT) as the time zone. | |
| 6. Submit and commit the changes. | |
| Datadog expects all the logs in GMT time zone by default. If the time zone of your Cisco Secure Web Appliance logs is not GMT, please change it to GMT. Here are the steps: | |
| 1. Go to **System Administration**, and then **Time Zone**. | |
| 2. Click on **Edit Settings**. | |
| 3. Select **GMT Offset** as the region. | |
| 4. Select **GMT** as the country. | |
| 5. Select **GMT (GMT)** as the time zone. | |
| 6. Submit and commit the changes. |
There was a problem hiding this comment.
Updated as per the suggestion.
datadog-assets
bot
added
docs/requested-changes
and removed
docs/review-requested
labels
|
We have set the version to 7.58.0. If this is intended for any future release, please let us know, as an update will be necessary for this PR. Thank you! |
michaelcretzman
previously approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR for a new integration Cisco Secure Web Appliance 1.0.0
Additional Notes
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged