Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for check_only integrations #18718

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Various fixes for check_only integrations #18718

wants to merge 3 commits into from
+15 −2

Conversation

james-eichelbaum
Copy link
Contributor

@james-eichelbaum james-eichelbaum commented Sep 30, 2024 •
edited
Loading

  • Fixes an issue where the display name is not normalized when creating check_only integrations
  • Updates the default type in conf.yaml.example to be integer, as number causes validations to fail
  • Adds a missing spec file for check_only integrations

@james-eichelbaum james-eichelbaum force-pushed the jte/09-30-fix_author_name_not_being_normalized branch from 28996d5 to 9ea4f71 Compare September 30, 2024 13:51
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (501c0e4) to head (8cc66d0).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
datadog_checks_dev 77.46% <ø> (ø)
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@james-eichelbaum james-eichelbaum force-pushed the jte/09-30-fix_author_name_not_being_normalized branch from 9ea4f71 to 8cc66d0 Compare October 8, 2024 17:03
@james-eichelbaum james-eichelbaum changed the title fix author name not being normalized Various fixes for check_only integrations Oct 8, 2024
@james-eichelbaum james-eichelbaum marked this pull request as ready for review October 8, 2024 17:16
@james-eichelbaum james-eichelbaum requested review from a team as code owners October 8, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraizu buraizu buraizu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
agent/review-requested dev_package dev/tooling docs/approved ecosystems/review-requested product/review-requested team/agent-integrations team/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-eichelbaum @buraizu