-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize KubeVirt integrations #18744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
…nce they share the same name value
NouemanKHAL
changed the title
Synchronize KubeVirt integrations
Finalize KubeVirt integrations
Oct 4, 2024
iliakur
approved these changes
Oct 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* rename namespace label to vmi_namespace for kubevirt_handler metrics * images folders * update the description of the can_connect metrics * add process_signatures entries * rename namespace label to vm_namespace for both vm and vmi metrics since they share the same name value * add missing units to kubevirt_controller 3150634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handles some comments from the KubeVirt PRs:
kubevirt_api
integration #18179kubevirt_controller
integration #18186kubevirt_handler
integration #18283Motivation
Synchronize all the 3 integrations to follow the same behavior:
namespace
->vm_namespace
).can_connect
metric.Additional Notes
For the kubevirt_handler, and kubevirt_controller metrics, the only metric that contains the
namespace
label arekubevirt_vmi
andkubevirt_vm
metrics, I confirmed that using:Both metrics share the same label values
name="aws-kubevirt-vm-6",namespace="default"
referring to the VM resource, example:So we can safely rename the
namespace
label tovm_namespace
to avoid collision with thenamespace
tag attached by the agent on Kubernetes which is different than the namespace where the VM is running.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged