Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide SQL Server deadlocks collection config #18755

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

nenadnoveljic
Copy link
Contributor

What does this PR do?

Unhide SQL Server deadlocks collection config.

Motivation

The agent and backend are ready. Frontend will be ready by the time the next agent version is released.

Additional Notes

The deadlocks collection remains disabled by default for now.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

github-actions bot commented Oct 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (797869d) to head (7d951e7).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 89.38% <ø> (+9.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nenadnoveljic nenadnoveljic merged commit b6cbfdb into master Oct 3, 2024
37 checks passed
@nenadnoveljic nenadnoveljic deleted the nenadnoveljic/unhide-deadlocks branch October 3, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants