[Backport 7.59.x] Fix tcp.current_established/tcp.connections metric types #18769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-agent-integrations-bot[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
(cherry picked from commit 990cc9b)
datadog-agent-integrations-bot
bot
requested a review
from a team
as a code owner
datadog-agent-integrations-bot
bot
requested a review
from a team
as a code owner
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Kyle-Neale
previously approved these changes
Oct 4, 2024
Kyle-Neale
approved these changes
Oct 4, 2024
HadhemiDD
pushed a commit
that referenced
this pull request
Oct 7, 2024
…8769) (cherry picked from commit 990cc9b) Co-authored-by: Branden Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 990cc9b from #18764.
What does this PR do?
Send
tcp.current_established/tcp.connectionsas gauge instead of rate/countadds tests for metric types
Motivation
https://datadoghq.atlassian.net/browse/WINA-1086
metrics added in #18294 but this case was missed
Additional Notes
no changelog b/c it's a fix for something not yet released (to be released in 7.58
this bug creates
INFOlogs of the formReview checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged