Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDM] [Cisco ACI] Refactor fabric test #18792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zoedt
Copy link
Contributor

@zoedt zoedt commented Oct 7, 2024

What does this PR do?

Refactoring the tests for Cisco ACI fabric, first iteration towards an easier testing/dev experience (for this PR #18747)

Summary of changes made

  • Reduce number of devices/interfaces to be more manageable
  • Update test fixtures accordingly
  • Organize metric assertions into group

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (50589cb) to head (acc0399).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
cisco_aci 89.37% <ø> (-5.68%) ⬇️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants