Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skip for distribution event #19052

Merged
merged 4 commits into from
Nov 28, 2024
Merged

add skip for distribution event #19052

merged 4 commits into from
Nov 28, 2024

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Nov 13, 2024

What does this PR do?

Couch version 3.4 introduced a new key in the _system api response:

"distribution_events": {
    "[email protected]": [
      [
        "2024-11-13T19:57:04Z",
        "nodeup"
      ]
    ],
    "[email protected]": [
      [
        "2024-11-13T19:57:04Z",
        "nodeup"
      ]
    ]
  }

Which we don't handle at the moment. This will skip over this key to make the integration still function.

Motivation:
https://datadoghq.atlassian.net/browse/AGENT-12655

Follow up:
https://datadoghq.atlassian.net/browse/AI-4598

Passes on 3.4.1 for me after patching.

  Running Checks
  ==============

    couch (8.0.0)
    -------------
      Instance ID: couch:1a8bdcb1f3798a84 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/couch.d/couch.yaml
      Total Runs: 1
      Metric Samples: Last Run: 2,386, Total: 2,386
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 4, Total: 4
      Average Execution Time : 433ms
      Last Execution Date : 2024-11-13 21:03:56 UTC (1731531836000)
      Last Successful Execution Date : 2024-11-13 21:03:56 UTC (1731531836000)


  Metadata
  ========
    config.provider: file
    config.hash: couch:1a8bdcb1f3798a84
    version.minor: 4
    version.patch: 1
    version.raw: 3.4.1
    version.scheme: semver
    version.major: 3
  

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (7494a92) to head (853b8c1).
Report is 75 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
couch 95.40% <100.00%> (+0.44%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 marked this pull request as ready for review November 28, 2024 04:48
@steveny91 steveny91 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into master with commit f3e57bd Nov 28, 2024
40 of 41 checks passed
@steveny91 steveny91 deleted the sy/couch-patch branch November 28, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants