Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LLMObs logs/metrics references #19554

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kyle-Verhoog
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog commented Feb 5, 2025

What does this PR do?

Remove references to logs and metrics being sent from the clients.

Motivation

It is now recommend using the LLM Observability product directly rather than sending logs and metrics. The logs and metrics code is being removed from the libraries.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

It is now recommend using the LLM Observability product directly rather than sending logs and metrics. The logs and metrics code is being removed from the libraries.
@Kyle-Verhoog Kyle-Verhoog force-pushed the kylev/drop-llmobs-logs-metrics branch from cd64a4c to 8494d27 Compare February 5, 2025 03:12
Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. Should we also remove the integration metrics from each corresponding metadata.csv which lists the provided integration metrics?
  2. Looks like the ootb dashboards are reliant on these metrics. Should we remove those from the dashboard as well or convert them to use APM trace metrics instead?

@Kyle-Verhoog
Copy link
Member Author

@Yun-Kim good catch. I'm ok to leave them for now in case people are using them and just remove the documentation to prevent further usage. When we go to do the customer notifs we can set a date to remove the metrics.

@Kyle-Verhoog
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 11, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-11 17:12:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-11 21:13:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@Kyle-Verhoog
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 05:32:35 UTC ℹ️ Start processing command /merge


2025-02-13 05:32:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-13 09:33:09 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@Kyle-Verhoog
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 10:36:33 UTC ℹ️ Start processing command /merge


2025-02-13 10:36:38 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-13 14:37:16 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants