-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LLMObs logs/metrics references #19554
base: master
Are you sure you want to change the base?
Conversation
It is now recommend using the LLM Observability product directly rather than sending logs and metrics. The logs and metrics code is being removed from the libraries.
cd64a4c
to
8494d27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- Should we also remove the integration metrics from each corresponding
metadata.csv
which lists the provided integration metrics? - Looks like the ootb dashboards are reliant on these metrics. Should we remove those from the dashboard as well or convert them to use APM trace metrics instead?
@Yun-Kim good catch. I'm ok to leave them for now in case people are using them and just remove the documentation to prevent further usage. When we go to do the customer notifs we can set a date to remove the metrics. |
/merge |
Devflow running:
|
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
What does this PR do?
Remove references to logs and metrics being sent from the clients.
Motivation
It is now recommend using the LLM Observability product directly rather than sending logs and metrics. The logs and metrics code is being removed from the libraries.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged