Fix http_check instance tag normalization to preserve minuses #21381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add normalize_instance_tag() method that correctly preserves minuses (-) in instance tags - Update documentation to reflect correct tag normalization behavior - Fix test expectations to match preserved minuses behavior - Resolves inconsistency with DataDog tag rules and other integrations Fixes DataDog#21103
DataDog auto-generates this file, so we should not modify the documentation manually. The actual behavior change is implemented in the code only.
- Remove trailing spaces and fix docstring formatting - Ensure proper line spacing according to DataDog linting rules
Restore instance tag generation in _get_service_checks_tags method that was accidentally removed in previous commit.
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
puretension
force-pushed
the
fix/http-check-normalize-tag-preserve-minuses-21103
branch
2 times, most recently
from
2519bc3 to
2025d19
Compare
buraizu
reviewed
Sep 17, 2025
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
|
@buraizu Thanks for catching the branding inconsistencies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the
http_checkintegration's instance tag normalization to correctly preserve minuses (-) in tag values, making it consistent with DataDog's official tag rules and other integrations.Motivation
Users reported in #21103 that the
http_checkintegration incorrectly converts minuses to underscores in instance tags, which violates DataDog's tag documentation and creates inconsistency with other integrations likepostgresthat preserve minuses correctly.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged