[sqlserver] Complete fix for schemas_collection errors on Azure SQL Database #21395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: puretension <[email protected]>
Signed-off-by: puretension <[email protected]>
Keep FK.object_id in GROUP BY clause to fix SQL 8120 error while maintaining backward compatibility with existing foreign key parsing. Signed-off-by: puretension <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
Remove FK.object_id from GROUP BY to match SELECT fields and prevent SQL aggregation errors while maintaining proper grouping. Signed-off-by: puretension <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Completes the fix for SQL Server integration errors when
schemas_collection.enabled: trueon Azure SQL Database. Adds missing FK.object_id to SELECT clause and handles None return values in deadlock collection.Motivation
Issue #20665 reports SQL syntax errors and Python TypeErrors on Azure SQL Database with schemas_collection enabled. While PR #20546 partially fixed this, the main FOREIGN_KEY_QUERY still needs FK.object_id in SELECT clause, and deadlock None handling was never addressed.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged