Remove deprovisioning metrics from OOB Karpenter Dashboard #21410
Conversation
| karpenter.controller.runtime.reconcile_errors.count,count,,error,,The count of reconciliation errors per controller,0,karpenter,,, | ||
| karpenter.controller.runtime.reconcile_panics.count,count,,,,Total number of reconciliation panics per controller,0,karpenter,,, | ||
| karpenter.controller.runtime.terminal.reconcile.errors.count,count,,,,Total number of terminal reconciliation errors per controller,0,karpenter,,, | ||
| karpenter.deprovisioning.actions_performed.count,count,,execution,,The count of deprovisioning actions performed. Labeled by deprovisioner,0,karpenter,,, |
There was a problem hiding this comment.
I don't think you should get rid of these. It might be better to just list them as deprecated and the version they were deprecated in.
temporal-github-worker-1
bot
dismissed
janine-c’s stale review
Review from janine-c is dismissed. Related teams and files:
- documentation
- karpenter/metadata.csv
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
| 'karpenter.controller.runtime.reconcile.time_seconds.count', | ||
| 'karpenter.controller.runtime.reconcile.time_seconds.sum', | ||
| 'karpenter.controller.runtime.reconcile_errors.count', | ||
| 'karpenter.deprovisioning.actions_performed.count', |
There was a problem hiding this comment.
Last change, can you leave the fixtures and the test alone? I think just shipping the dashboard changes will be enough here.
There was a problem hiding this comment.
Hey, it seems like when I remove the fixtures and test it's breaking some of the checks since it is expecting the metrics I removed to be in the karpenter_metrics.txt file. Can I remove them from the test in this case?
ddog-nasirthomas
force-pushed
the
nasir.thomas/depreciate-deprovisioning-metrics
branch
2 times, most recently
from
8d0bc6a to
466e519
Compare
What does this PR do?
Removes deprovisioning metrics from the Karpenter integration
Motivation
The current OOB dashboard for Karpenter still includes several deprovisioning metrics that were deprecated in the latest major upgrade of Karpenter. These metrics were last available in v0.32 and are no longer present in versions 1.0 and later. Details on the deprecation can be found here: https://karpenter.sh/v0.32/upgrading/v1beta1-migration/#metrics
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged