Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zfs integration #2391

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

etnbrd
Copy link

@etnbrd etnbrd commented May 23, 2024

What does this PR do?

A first working version of an Zfs integration for the zfs filesystem and pools.

Motivation

I've been using this integration on my servers for the past few months, and I wanted to share with the community.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests -> I didn't have the time to write unit tests yet, and not sure what would be a good testing strategy given the tight coupling with the zfs command. I might add some tests later.
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

I'm not sure about the app_uuid and the source_type_id in the manifest.json, so I left them out.

@etnbrd etnbrd requested review from a team as code owners May 23, 2024 15:08
@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review from a docs team editor label May 23, 2024
@jhgilbert
Copy link
Contributor

jhgilbert commented May 23, 2024

I've created a docs review ticket so we can follow up when this is ready for an editorial review. Thanks!

@jhgilbert jhgilbert self-requested a review May 29, 2024 15:53
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a style suggestion, thanks!

zfs/README.md Outdated Show resolved Hide resolved
zfs/README.md Outdated Show resolved Hide resolved
zfs/README.md Outdated Show resolved Hide resolved
zfs/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review from a docs team editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants