-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zfs integration #2391
Open
etnbrd
wants to merge
12
commits into
DataDog:master
Choose a base branch
from
etnbrd:etnbrd/zfs-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add zfs integration #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhgilbert
added
the
editorial review
Waiting on a more in-depth review from a docs team editor
label
May 23, 2024
I've created a docs review ticket so we can follow up when this is ready for an editorial review. Thanks! |
jhgilbert
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a style suggestion, thanks!
Co-authored-by: Jen Gilbert <[email protected]>
Co-authored-by: Jen Gilbert <[email protected]>
Co-authored-by: Jen Gilbert <[email protected]>
Co-authored-by: Jen Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A first working version of an Zfs integration for the zfs filesystem and pools.
Motivation
I've been using this integration on my servers for the past few months, and I wanted to share with the community.
Review checklist
no-changelog
label attachedzfs
command. I might add some tests later.Additional Notes
I'm not sure about the
app_uuid
and thesource_type_id
in themanifest.json
, so I left them out.