Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCS-7761) Update screenshots for nav #2393

Closed
wants to merge 2 commits into from
Closed

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented May 23, 2024

What does this PR do?

This PR crops the outdated nav from a few screenshots

Motivation

DOCS-7761

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@buraizu buraizu requested a review from a team as a code owner May 23, 2024 23:03
@buraizu buraizu requested review from bgoldberg122 and removed request for a team May 23, 2024 23:03
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@bgoldberg122
Copy link
Contributor

Hi 👋 We can't crop the images because we have a requirement for aspect ratio to ensure quality. If you want the new nav in the photos, you would have to re-take the screenshots with the new nav bar

@bgoldberg122
Copy link
Contributor

@buraizu #2393 (comment)

@buraizu
Copy link
Contributor Author

buraizu commented May 30, 2024

https://docs.datadoghq.com/developers/integrations/?tab=integrations#requirements

Hi 👋 We can't crop the images because we have a requirement for aspect ratio to ensure quality. If you want the new nav in the photos, you would have to re-take the screenshots with the new nav bar

@bgoldberg122 thanks for following up! Could you let me know what the required aspect ratio is? I checked in the requirements but couldn't find any information about that.

Copy link

github-actions bot commented Jun 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@bgoldberg122
Copy link
Contributor

Sorry, I must have missed your comment. You can see the failed validation messages from clicking details next to the failed CI job: https://github.com/DataDog/integrations-extras/pull/2393/checks?check_run_id=25909541375

@bgoldberg122 bgoldberg122 deleted the docs7761/nav-updates-4 branch September 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants