Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Optimize layout and update EMQX logo #2444

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ysfscream
Copy link

@ysfscream ysfscream commented Jul 19, 2024

What does this PR do?

This PR enhances the EMQX integration for Datadog by improving the dashboard layout, updating the EMQX logo, and enhancing overall visual consistency. Specifically, it:

  • Optimizes the dashboard panel layout and design for better user experience
  • Updates the EMQX logo to align with our latest brand identity
  • Improves the overall visual consistency of the integration

Motivation

As an official developer and maintainer of EMQX, we are committed to providing the best possible experience for users of our Datadog integration. This update aims to enhance the visual appeal and usability of the EMQX dashboard within Datadog, ensuring it reflects our current branding and provides a more intuitive interface for monitoring EMQX deployments.

Review checklist

  • PR has a meaningful title
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

I can confirm that these changes are in line with our current branding guidelines and UX best practices. The updated dashboard layout has been tested internally with various EMQX deployment scenarios to ensure it provides valuable insights at a glance.

- Improve dashboard panel layout and design for better UX
- Update EMQX logo to align with latest brand identity
- Enhance overall visual consistency of the integration
@ysfscream ysfscream requested review from a team as code owners July 19, 2024 07:59
emqx/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: emarsha94 <[email protected]>
@emarsha94
Copy link
Collaborator

Waiting on logo to be published on our end then will merge!

@emarsha94
Copy link
Collaborator

Please update you branch and then we can merge

@ysfscream
Copy link
Author

@emarsha94 Updated.

@emarsha94
Copy link
Collaborator

hey @ysfscream Could you run "ddev validate config emqx -s"? This will fix any other issues you have in the files. Once that is done, the last validation should pass!!

@ysfscream
Copy link
Author

@emarsha94 sorry, but I don't know how to run ddev validate config emqx -s locally. Could you please give me a hand? Thank you.

@emarsha94
Copy link
Collaborator

Hi @ysfscream you should have ddev installed on your machine already since you opened the PR. If not, you will need to install ddev and pull down this branch and run the command. We are unable to do this for you since this is local to your machine and branch

@ysfscream
Copy link
Author

ysfscream commented Sep 25, 2024

I don't know why. It has run successfully locally for me, but CI still has an error.

image image

@emarsha94
Copy link
Collaborator

I don't know why. It has run successfully locally for me, but CI still has an error.

image image

Can you try running the command: ddev validate config emqx -s

You may need to update your ddev version if that doesn't work,

@ysfscream
Copy link
Author

ysfscream commented Sep 26, 2024

I run it on my screenshot...

image image

This is the latest version...

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants