Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new OceanBase Cloud Integration (ECOINT-7) #2456

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kyle-oceanbase
Copy link

What does this PR do?

Add a new integration for OceanBase Cloud.

Motivation

OceanBase Cloud provides fully managed database services with elastic scalability, ultra-fast performance, and high compatibility on global cloud infrastructure.

We Use the OceanBase Cloud Datadog integration to export metrics from OceanBase Cloud clusters to Datadog

This is an API based integration, which should only be installed in OceanBase Cloud environments.

What inspired you to submit this pull request?
Our users want to use datadog to monitor their OceanBase Cloud Clusters.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

@kyle-oceanbase kyle-oceanbase requested review from a team as code owners August 1, 2024 11:49
@cswatt cswatt added the editorial review Waiting on a more in-depth review from a docs team editor label Aug 1, 2024
@cswatt
Copy link
Contributor

cswatt commented Aug 1, 2024

Added DOCS-8606 to review

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up, requested some minor edits and posted a couple of questions on the updated doc

oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion per the documentation style guide, but otherwise looks good for docs and approving

oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/manifest.json Outdated Show resolved Hide resolved
oceanbasecloud/manifest.json Outdated Show resolved Hide resolved
oceanbasecloud/manifest.json Outdated Show resolved Hide resolved
oceanbasecloud/images/logo.png Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/README.md Outdated Show resolved Hide resolved
oceanbasecloud/images/host-performance.png Outdated Show resolved Hide resolved
oceanbasecloud/images/transaction.png Outdated Show resolved Hide resolved
oceanbasecloud/images/performance-and-sql.png Outdated Show resolved Hide resolved
@sunzhaoyang
Copy link

@emarsha94 Hello, may I ask if there are any other content that need revised? Can it be approved now?

@dd-dominic dd-dominic changed the title Add a new OceanBase Cloud Integration Add a new OceanBase Cloud Integration (ECOINT-7) Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants