Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying supported Metrics for Embrace integration #2478

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

scottieb3
Copy link

What does this PR do?

Updating the metadata for Metrics supported in the Embrace integration

Motivation

Following guidance from Datadog Tech Partnerships team

Review checklist

  • [ ✅ ] PR has a meaningful title or PR has the no-changelog label attached
  • [ ➖] Feature or bugfix has tests
  • Git history is clean
  • [ ➖ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • [ ➖] If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@scottieb3
Copy link
Author

@davidlawrencer

@scottieb3
Copy link
Author

@mfrishert

Copy link
Author

@scottieb3 scottieb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated based on Datadog's response to open questions (via email)

@scottieb3
Copy link
Author

@davidlawrencer + @mfrishert ( @jschoijet ): anything obvious I'm missing before I ping our Datadog contacts?
It keeps failing on the csv, but I'm following docs (here )

@jschoijet
Copy link

@davidlawrencer + @mfrishert ( @jschoijet ): anything obvious I'm missing before I ping our Datadog contacts? It keeps failing on the csv, but I'm following docs (here )

It’s confusing. Looks like It’s failing because service_checks expects a metadata_path:

"service_checks": {
        "metadata_path": "assets/service_checks.json"
 }

But according to docs it can be {}. Try changing it to the code I mentioned. But worth to check with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants