Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for Mergify built-in integration (ECOINT-20) #2487

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Prepare for Mergify built-in integration (ECOINT-20) #2487

merged 2 commits into from
Oct 21, 2024

Conversation

DouglasBlackwood
Copy link
Contributor

@DouglasBlackwood DouglasBlackwood commented Sep 17, 2024 •
edited
Loading

What does this PR do?

Rename the agent integration to "Mergify [deprecated]".

Create a new tile for the OAuth integration.

Motivation

Integration documentation

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch 3 times, most recently from eae1a01 to fa29adf Compare September 19, 2024 14:00
@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch 2 times, most recently from ed88b72 to cc69477 Compare September 28, 2024 10:04
@DouglasBlackwood DouglasBlackwood marked this pull request as ready for review September 28, 2024 10:05
@DouglasBlackwood DouglasBlackwood requested a review from a team as a code owner September 28, 2024 10:05
@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch from cc69477 to 8fdd690 Compare September 30, 2024 14:43
neko-dd
neko-dd reviewed Sep 30, 2024
View reviewed changes
mergify/README.md Outdated Show resolved Hide resolved
mergify/README.md Outdated Show resolved Hide resolved
mergify/README.md Outdated Show resolved Hide resolved
mergify/README.md Outdated Show resolved Hide resolved
mergify/README.md Outdated Show resolved Hide resolved
mergify/README.md Outdated Show resolved Hide resolved
mergify/README.md Outdated Show resolved Hide resolved
mergify/README.md Outdated Show resolved Hide resolved
mergify/assets/dashboards/mergify_overview.json Outdated Show resolved Hide resolved
mergify/manifest.json Outdated Show resolved Hide resolved
@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch from 8fdd690 to 4e565ec Compare October 1, 2024 08:35
@dd-dominic dd-dominic changed the title Prepare for Mergify built-in integration Prepare for Mergify built-in integration (ECOINT-20) Oct 1, 2024
neko-dd
neko-dd approved these changes Oct 1, 2024
View reviewed changes
mergify/manifest.json Outdated Show resolved Hide resolved
@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch 9 times, most recently from 0a59fb8 to 609ca0d Compare October 3, 2024 09:36
eho1307
eho1307 requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@eho1307 eho1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. I've added comments inline. Could you also upload an svg version of your logo? You can create a new subfolder under assets called 'logos'.

mergify_oauth/README.md Outdated Show resolved Hide resolved
mergify_oauth/README.md Outdated Show resolved Hide resolved
mergify_oauth/README.md Outdated Show resolved Hide resolved
mergify_oauth/assets/dashboards/mergify_overview.json Outdated Show resolved Hide resolved
mergify_oauth/manifest.json Outdated Show resolved Hide resolved
@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch 3 times, most recently from 2dfe9f5 to 80435ed Compare October 7, 2024 08:10
@DouglasBlackwood
Copy link
Contributor Author

@eho1307 I addressed your remarks and updated the PR.

@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch 2 times, most recently from 3ea43ed to b5447c4 Compare October 7, 2024 15:17
@DouglasBlackwood
Rename Mergify agent integration
9c6763d 
This agent integration will soon be removed. An OAuth integration will replace it.
@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch from b5447c4 to 77d16af Compare October 10, 2024 07:22
@DouglasBlackwood DouglasBlackwood force-pushed the update-readme-for-oauth-integration branch from 77d16af to a095f8e Compare October 18, 2024 13:40
@HadhemiDD HadhemiDD added this pull request to the merge queue Oct 21, 2024
Merged via the queue into DataDog:master with commit 1e4e12a Oct 21, 2024
27 checks passed
@eho1307 eho1307 requested review from a team and bgoldberg122 and removed request for a team October 21, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neko-dd neko-dd neko-dd approved these changes

@eho1307 eho1307 eho1307 approved these changes

@iliakur iliakur iliakur approved these changes

@bgoldberg122 bgoldberg122 Awaiting requested review from bgoldberg122 bgoldberg122 was automatically assigned from DataDog/ecosystems-review

Assignees
No one assigned
Labels
agent/approved docs/approved ecosystems/review-requested kind/technology-partner product/approved product/logos-complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DouglasBlackwood @iliakur @eho1307 @neko-dd @HadhemiDD