-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe new metrics provided by VNS3 integration, update pointers, modernize language, add example dashboard #2489
base: master
Are you sure you want to change the base?
Conversation
Third time's the charm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! I just left a small suggestion to make one of the links more descriptive.
Co-authored-by: Brett Blue <[email protected]>
Actually I may have an issue with the dashboard.json in here. |
Support was very helpful as always - one of the widgets on that dashboard was somehow tainted. JSON file imports correctly after recreating that widget. |
Not to nag, just making sure this hasn't dropped off the radar. |
@bob-smetana - Thanks for this and apologies for the delay! We still need a couple required approvals before merging. Let me ping them to make sure it's on their radar. CC @DataDog/agent-integrations @DataDog/reporting-and-sharing |
Co-authored-by: Steven Yuen <[email protected]>
Polite reminder that this is ready for merge |
@steveny91 - Could you please merge this one for @bob-smetana ? Docs team doesn't usually merge these. Thanks! |
What does this PR do?
Brings the description of the VNS3 integration up to reflect current reality.
Motivation
A new version of the datadog-agent plugin for VNS3 has been released, adding new reported metrics and other functionality.
Review checklist
no-changelog
label attachedAdditional Notes
n/a