Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe new metrics provided by VNS3 integration, update pointers, modernize language, add example dashboard #2489

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bob-smetana
Copy link

@bob-smetana bob-smetana commented Sep 19, 2024

What does this PR do?

Brings the description of the VNS3 integration up to reflect current reality.

Motivation

A new version of the datadog-agent plugin for VNS3 has been released, adding new reported metrics and other functionality.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

n/a

@bob-smetana bob-smetana requested review from a team as code owners September 19, 2024 18:27
@bob-smetana
Copy link
Author

Third time's the charm!

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I just left a small suggestion to make one of the links more descriptive.

vns3/README.md Outdated Show resolved Hide resolved
@bob-smetana
Copy link
Author

Actually I may have an issue with the dashboard.json in here.
Guess regular support will be the best resource for that?

@bob-smetana
Copy link
Author

Support was very helpful as always - one of the widgets on that dashboard was somehow tainted. JSON file imports correctly after recreating that widget.
I am satisfied that this is ready for merge upon final approval.

@bob-smetana
Copy link
Author

Not to nag, just making sure this hasn't dropped off the radar.
Still happy with latest commit, ready for a merge.

@brett0000FF
Copy link
Contributor

@bob-smetana - Thanks for this and apologies for the delay! We still need a couple required approvals before merging. Let me ping them to make sure it's on their radar.

CC @DataDog/agent-integrations @DataDog/reporting-and-sharing

vns3/CHANGELOG.md Outdated Show resolved Hide resolved
@bob-smetana
Copy link
Author

Polite reminder that this is ready for merge

@brett0000FF
Copy link
Contributor

@steveny91 - Could you please merge this one for @bob-smetana ? Docs team doesn't usually merge these. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants