Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MongoDB Atlas Collstats + DB Stats metrics #2491

Merged
merged 18 commits into from
Oct 29, 2024

Conversation

Salil999
Copy link
Contributor

What does this PR do?

  • Added metrics descriptions for new metrics that are pushed to DataDog via the Atlas integration.
  • Added metrics description for collstats metrics
  • Added metrics description for dbstats metrics

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

@Salil999 Salil999 changed the title Adding MongoDB Collstats + DB Stats metrics Adding MongoDB Atlas Collstats + DB Stats metrics Oct 2, 2024
@Salil999 Salil999 marked this pull request as ready for review October 2, 2024 13:22
@Salil999 Salil999 requested a review from a team as a code owner October 2, 2024 13:22
Copy link
Contributor

@eho1307 eho1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this in our shared slack channel but sharing here as well:

It would be great if you could also highlight these new metrics in the dashboard that’s included with the integration. The best way to update it is to:

  1. Copy the json from here into your sandbox in a new dashboard https://github.com/DataDog/integrations-extras/tree/master/mongodb_atlas/assets/dashboards
  2. Make the necessary changes and add new widgets
  3. Export it as JSON
  4. Replace the file from step 1 and add it to your pull request

Integration Dashboards are typically where customers start when it comes to monitoring another technology and so we want to make sure it’s as comprehensive as possible. Otherwise metrics just get buried within a Datadog customer’s org.

@eho1307
Copy link
Contributor

eho1307 commented Oct 16, 2024

Hi @Salil999 Could I also ask you to update the author within the manifest.json to MongoDB as well as the codeowners file? We'd like to acknowledge that this integration is built and maintained by Datadog.

@sunfranklin
Copy link
Contributor

Hi @Salil999 Could I also ask you to update the author within the manifest.json to MongoDB as well as the codeowners file? We'd like to acknowledge that this integration is built and maintained by Datadog.

Hi @eho1307, just to clarify, should the author be a mongodb contact or a datadog contact? thanks!

@eho1307
Copy link
Contributor

eho1307 commented Oct 17, 2024

Hi @Salil999 Could I also ask you to update the author within the manifest.json to MongoDB as well as the codeowners file? We'd like to acknowledge that this integration is built and maintained by Datadog.

Hi @eho1307, just to clarify, should the author be a mongodb contact or a datadog contact? thanks!

Within the manifest.json, you can update the author fields to contacts at MongoDB, for example:

"author": {
"support_email":
"name": "MongoDB",
"homepage": https://www.mongodb.com/
"sales_email":

The support email and sales email should be MongoDB email addresses.

@Salil999 Salil999 requested a review from a team as a code owner October 17, 2024 18:27
@eho1307 eho1307 requested a review from a team October 17, 2024 19:39
mongodb_atlas/metadata.csv Outdated Show resolved Hide resolved
mongodb_atlas/metadata.csv Outdated Show resolved Hide resolved
@eho1307
Copy link
Contributor

eho1307 commented Oct 25, 2024

Hi @Salil999 We'll merge this PR on Monday. Thanks for your patience.

@JoshPatel13 JoshPatel13 added this pull request to the merge queue Oct 29, 2024
Merged via the queue into DataDog:master with commit 4bdfc5c Oct 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants