win_docker_daemon: initial release #538
Conversation
A plugin that gets docker stats from the docker api. This is useful if running windows containers where the existing docker integration cannot provide stats. This module borrows heavily from the old docker_daemon module.
| ## Data Collected | ||
|
|
||
| ### Metrics | ||
| | name | type | description | |
There was a problem hiding this comment.
You don't need to inline the metrics in the README here, just adding:
See [metadata.csv](<LINK_TO_METADATA.CSV_FILE>) for a full list of provided metrics by this integration.
will inline automatically the metrics table in the public Datadog documentation.
|
|
||
| To install the win_docker_daemon check on your host: | ||
|
|
||
| 1. Install the [developer toolkit](https://docs.datadoghq.com/developers/integrations/new_check_howto/#developer-toolkit) on any machine. |
There was a problem hiding this comment.
Link should be set as reference in the whole README.md
|
|
||
| ## Overview | ||
|
|
||
| This check monitors [win_docker_daemon][1] through the Datadog Agent. This integration targets gathering docker stats from the daemon api for Windows containers. The core docker integration uses the filesystem\cgroups to gather performance stats. This approach does not work with Windows. This integration attempts to create the same metrics as the docker integration. It currently targets: |
There was a problem hiding this comment.
| This check monitors [win_docker_daemon][1] through the Datadog Agent. This integration targets gathering docker stats from the daemon api for Windows containers. The core docker integration uses the filesystem\cgroups to gather performance stats. This approach does not work with Windows. This integration attempts to create the same metrics as the docker integration. It currently targets: | |
| This check monitors [win_docker_daemon][1] through the Datadog Agent. This integration targets gathering docker stats from the daemon api for Windows containers. The core docker integration uses the filesystem\cgroups to gather performance stats which is not applicable on Windows. This integration attempts to collect the same metrics as the docker integration. It currently targets: |
We should add a link to the docker integration that is mentioned.
| - memory | ||
| - network | ||
|
|
||
| This module borrows heavily from the old docker_daemon plugin. |
|
|
||
| Need help? Contact [Datadog support][6]. | ||
|
|
||
| [1]: **LINK_TO_INTEGRATION_SITE** |
|
|
||
|
|
||
| ### Events | ||
| - Die |
There was a problem hiding this comment.
Event description is missing
|
|
||
|
|
||
| ### Service Checks | ||
| - docker.exit |
There was a problem hiding this comment.
Service check description is missing
| [6]: https://docs.datadoghq.com/help | ||
|
|
||
|
|
||
| ### TODO's |
There was a problem hiding this comment.
This should be removed in the final version of the README.md
|
Hi @Dan70402, It seems we're planning to include this functionality out fo the box soon so it's probably better to wait a bit and see if what we provide covers your needs. |
|
Thanks for that info @hithwen. From what I could gather in some threads was windows container monitoring was a small use-case and less likely to be implemented. Do you have any idea what "soon" will be? weeks, months, year? If this PR is going to overlap with an upcoming feature it can be closed. |
|
Hi @Dan70402 the team is currently working on this, we expect it to be ready in a couple of months. |
|
That's good to hear. No need for this PR then. Feel free to close. |
What does this PR do?
A plugin that gets docker stats from the docker api. This is useful if running windows containers where the existing docker integration cannot provide stats. This module borrows heavily from the old docker_daemon module.
Motivation
To get similar performance stats from windows docker containers as are provided from the linux docker integration.
DataDog/docker-dd-agent#175
Review checklist
no-changeloglabel attachedAdditional Notes
None