Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed several workloads where
UTF_8$Encoder.encodeLoop
called fromStatsDProcessor$ProcessingTask.writeBuilderToSendBuffer
is very prominent in the profile. We also noticed that a lot of time was spent getting and putting the characters/bytes, i.e.,StringCharBuffer.get
andDirectByteBuffer.put
(see screenshot).This is actually quite similar to the grey frames in the screenshot in the following comment (although it dealt with a completely separate issue): #203 (comment)
After applying the changes suggested in this PR (replacing the
CharsetEncoder
interface with plainString.getBytes
) performance improved dramatically andwriteBuilderToSendBuffer
is no longer visible in the profile.We also found a pretty old blogpost benchmarking the two: https://www.evanjones.ca/software/java-string-encoding.html.