Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some composite data tests #481

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Conversation

scottopell
Copy link
Contributor

This make a few changes:

  1. Moves the "is attribute of type XYZ" check inside each attribute class
  2. Adds a test case with both a simple compositedata attribute and a nested compositedata attribute (the latter is not supported)
  3. Small exception handler cleanup with telemetry bean registration.

I wanted to change the "is attribute of type XYZ" check to use a more dynamic method to avoid having to list all possible subclasses (ref TabularData vs TabularDataSupport).

Unfortunately this is not an easy change due to the fact that TabularDataSupport actually implements Map, so TabularDataSupport was getting picked up as a JmxComplexAttribute vs a JmxTabularAttribute.
Change was attempted in baa60df

@scottopell scottopell requested a review from a team as a code owner September 28, 2023 19:48
Copy link
Contributor

@rayz rayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😃

@scottopell scottopell merged commit 36da049 into master Oct 19, 2023
2 checks passed
scottopell added a commit that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants