[Metricsfetcher] Change broker query to use last instead of rollup #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravisha91
force-pushed
the
kravishankar/STREAMS-2057-fix
branch
from
c793136
to
06eebc0
Compare
kravisha91
force-pushed
the
kravishankar/STREAMS-2057-fix
branch
from
06eebc0
to
82e2a9c
Compare
kphelps
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently there were a few occurrences on kafka metrics cluster when a rebalance operation was triggered (where a cluster was due a rebalance) and one of the broker which was recently replacement shot up to 90% in disk usage. The reason was due to a misinterpretation of metrics when fetched using metricsfetcher which uses a rollup function over 1 hour to get the avg free disk free per broker for a cluster which later gets used by topicmappr to compute the replica movement. For a more ideal and a reliable solution replacing
rollupwithlast. More details here in the notebook - https://ddstaging.datadoghq.com/notebook/6622198/metricsfetcher-query-change-testing