Merge branch 'main' into sopell/smaps-pathnames-whitespace

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   configuration option `sample_period_milliseconds` in `lading.yaml`.
 - Users can now configure expvar scraping on https endpoints, skipping certificate validation.
 - `smaps` parsing logic correctly collects memory region pathnames that contain whitespace
+- Fixes issue when parsing `NaN` values from a prometheus endpoint
 
 ## [0.25.4]
 ## Changed

lading/src/target_metrics/prometheus.rs

@@ -276,6 +276,11 @@ pub(crate) async fn scrape_metrics(
                     }
                 };
 
+                if value.is_nan() {
+                    warn!("Skipping NaN gauge value");
+                    continue;
+                }
+
                 gauge!(format!("target/{name}"), &all_labels.unwrap_or_default()).set(value);
             }
             Some(MetricType::Counter) => {
@@ -287,6 +292,11 @@ pub(crate) async fn scrape_metrics(
                     }
                 };
 
+                if value.is_nan() {
+                    warn!("Skipping NaN counter value");
+                    continue;
+                }
+
                 let value = if value < 0.0 {
                     warn!("Negative counter value unhandled");
                     continue;