Module-based rule evaluation precedence #353
Open
+5,188
−1,559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 84.68% 84.91% +0.22%
==========================================
Files 153 157 +4
Lines 7889 7993 +104
Branches 3520 3556 +36
==========================================
+ Hits 6681 6787 +106
+ Misses 460 459 -1
+ Partials 748 747 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-27 22:03:31 Comparing candidate commit 8551f2e in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics. scenario:global-benchmark.random
|
Anilm3
commented
Nov 25, 2024
| return std::hash<std::string_view>{}(address); | ||
| } | ||
|
|
||
| struct target_address { |
There was a problem hiding this comment.
These are not currently used, but I plan to start using them soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new concept of
modulesto better organise rules based on their precedence. Modules are introduced as a generic mechanism which contains a set of rules in the required order (user / base, blocking, etc). Individual modules can have optional grouping, which is introduced specifically for the purpose of having independent collections within thewafmodule, as the short-circuit evaluation follows a different criteria due to rules being grouped by type.The modules introduced are the following:
network-acl,authentication-acl,custom-acl,configuration,business-logic,rasp,waf. The network and authentication modules do not follow the provided timeout, and the ordering of each module changes a little bit based on whether user (Custom) or base (DD) rules should take precedence.Related Jira: APPSEC-55598