Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameter to raw_configuration #367

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Feb 8, 2025

This PR only renames ddwaf::parameter to ddwaf::raw_configuration and moves it to configuration/common.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 98.63014% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (621835e) to head (7a3bd1c).

Files with missing lines Patch % Lines
src/configuration/data_parser.cpp 90.00% 0 Missing and 1 partial ⚠️
src/configuration/legacy_rule_parser.cpp 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   85.30%   85.35%   +0.04%     
==========================================
  Files         163      163              
  Lines        8188     8206      +18     
  Branches     3606     3605       -1     
==========================================
+ Hits         6985     7004      +19     
  Misses        440      440              
+ Partials      763      762       -1     
Flag Coverage Δ
waf_test 85.35% <98.63%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 8, 2025

Benchmarks

Benchmark execution time: 2025-02-09 13:03:58

Comparing candidate commit 19b4ab2 in PR branch anilm3/rename-parameter with baseline commit 621835e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3 Anilm3 force-pushed the anilm3/rename-parameter branch from e825ee6 to 19b4ab2 Compare February 9, 2025 12:39
@Anilm3 Anilm3 marked this pull request as ready for review February 10, 2025 08:53
@Anilm3 Anilm3 requested a review from a team as a code owner February 10, 2025 08:53
Copy link
Collaborator

@estringana estringana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anilm3 Anilm3 merged commit 345cda7 into master Feb 10, 2025
100 checks passed
@Anilm3 Anilm3 deleted the anilm3/rename-parameter branch February 10, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants