This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
[Fixes #14] Merge array of route paths #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋 Is this project still maintained? We hope that this is the case ;-) It would be nice to see any official reaction from DataDog. |
|
@ruettenm The project is no longer maintained as it only existed to cover a use case that is a subset that our APM product now offers out of the box in addition to many other features. I would recommend to give APM a try, and if you're not ready to make the jump we'll officially deprecate the library so that it's clear it should be forked by any user who still needs it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This closes #14 but merging an array of route paths. I took a simple approach by checking if the
stris actually an array, and just joining the items on,- this would create a tag specific to that grouping of routes.I also added a test - it fails without the change to
lib/index.js(it throws the error from #14) but I didn't see a clear way to test against the actual end-result tag. Any ideas/suggestions there would be great!This is currently causing some complications in the project I work on, so if there's a way we can get this published that'd be awesome. Let me know how I can help!