This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Pipe character bug fix with tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix: Sending metrics with pipes in the route
- Configurable with 'method' option on middleware initialization
It already existed so adding the code was not the appropriate path to take. In the mean time, I standardized the `method` option to be treated similarly to how the other options are treated
That’s now part of test setup for the request object
New unit tests for connect-datadog library
|
Hello there, I was looking at #14 and could not find (quickly enough) a source on the "delimiter" that pipe would be on DataDog. Do you have a documentation link maybe? |
|
Found it: https://docs.datadoghq.com/tagging/#defining-tags It however says invalid characters are converted to underscores by default. I'm wondering what's the best course of action to take for more complicated regexes: for example, I have: As I understand, it would be converted to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics sent through
connect-datadogcannot contain a route with a pipe character, since the pipe character is used as a delimiter. This fix replaces the pipe character with a configurable replacement character.We also introduce a few additional improvements, including: