-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update xpassing baggage tests for unimplemented languages #3773
base: main
Are you sure you want to change the base?
Conversation
"""Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything""" | ||
Test_Headers_Baggage._assert_valid_baggage(self, test_library) | ||
|
||
with test_library: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use the same "_assert_valid_baggage" for both checks? Adding a new param to the method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] Is there any way we can make the same check for our baggage disabled tests (D003 and D007)?
I spoke with @cbeauchesne, and we concluded that the only way to pass the baggage_disable tests right now is to skip them for languages that haven’t implemented baggage yet. Since there’s no available telemetry or logs to differentiate which languages support baggage, I added a change to skip the tests for those languages. Let me know what you think! |
Motivation
Currently, some of the baggage tests are xpassing for langauges where baggage has not been implemented yet (this is because of the negative assertion tests).
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present