Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Enable V3 Login events tests #3815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leiyks
Copy link

@Leiyks Leiyks commented Jan 14, 2025

Motivation

Enable V3 Login events tests now that it is implemented on the PHP tracer.

Changes

  • Enable V3 Login events tests
  • Disable V2 Login events tests
  • Update the weblog to call the new functions that have been implemented

Related Jiras: APPSEC-56144, APPSEC-56145, APPSEC-56146

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@Leiyks Leiyks requested review from a team as code owners January 14, 2025 15:24
@Leiyks Leiyks force-pushed the leiyks-enable-v3-login-event branch from 24b64b1 to b233cfc Compare January 14, 2025 15:25
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are test failures related with this PR

Signed-off-by: Alexandre Rulleau <[email protected]>
@Leiyks Leiyks force-pushed the leiyks-enable-v3-login-event branch from b233cfc to 8e901fe Compare January 15, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants