Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[golang] appsec: meta_struct Security Events #3845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[golang] appsec: meta_struct Security Events #3845

wants to merge 1 commit into from

Conversation

eliottness
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness eliottness force-pushed the eliottness/APPSEC-53213/meta-struct branch from 92486d9 to a792c75 Compare January 17, 2025 14:50
@eliottness eliottness marked this pull request as ready for review January 17, 2025 14:54
@eliottness eliottness requested a review from a team as a code owner January 17, 2025 14:54
@eliottness eliottness force-pushed the eliottness/APPSEC-53213/meta-struct branch from f8cdd52 to 86faec2 Compare January 17, 2025 15:43
cbeauchesne
cbeauchesne requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@eliottness
Copy link
Contributor Author

@cbeauchesne For some unknown reason, the go proxy won't take the latest commit from main to run this. Will wait for monday 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeauchesne cbeauchesne cbeauchesne requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliottness @cbeauchesne