[datadog_synthetics_test] Add comment regarding browser step available auths #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineDona
changed the title
etnbrd
approved these changes
Nov 21, 2024
HantingZhang2
approved these changes
Nov 25, 2024
HantingZhang2
deleted the
antoine.donascimento/SYNTH-15787/aadd-all-auth-methods-for-browser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initially, we wanted to implement all auth methods used by api tests for browser tests in terraform. Turns out that dogweb only supports web basic auth for browser tests, and as a side effect, also NTLM and Digest which also use
usernameandpassword. We thus added a comment to explain that in terraform.