You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check to make sure JMX image of the Agent is deployed. Also has a new function called InternalRegistryFullImagePathExists that allows me to use a computed Docker image path. This means that tests that don't care about the JMX image won't have to rely on that job in the gitlab pipeline.
Which scenarios this will impact?
Docker end to end test.
Motivation
To run e2e tests for JMXFetch we need the Docker image with Java published.
Additional Notes
This PR will break main on the Agent if merged before the update the gitlab ci definitions that publish the JMX docker image for QA. It needs the PR here to be merged first.
2024-11-27 16:54:48 UTC ℹ️ MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2024-11-27 20:54:50 UTC⚠️MergeQueue: This merge request was unqueued
2024-11-28 12:46:57 UTC ℹ️ MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carlosroman
force-pushed
the
carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests-fix
branch
from
dd-devflow
bot
added
mergequeue-status: waiting
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
What does this PR do?
Added a check to make sure JMX image of the Agent is deployed. Also has a new function called
InternalRegistryFullImagePathExiststhat allows me to use a computed Docker image path. This means that tests that don't care about the JMX image won't have to rely on that job in the gitlab pipeline.Which scenarios this will impact?
Docker end to end test.
Motivation
To run e2e tests for JMXFetch we need the Docker image with Java published.
Additional Notes
This PR will break
mainon the Agent if merged before the update the gitlab ci definitions that publish the JMX docker image for QA. It needs the PR here to be merged first.