Skip to content

Commit

Permalink
fix: app.tsx import constant (#2252)
Browse files Browse the repository at this point in the history
* fix: app.tsx import constant

Signed-off-by: Licho <[email protected]>

* refactor: remove comment-on-issue

Signed-off-by: Licho <[email protected]>

* remove submodule

---------

Signed-off-by: Licho <[email protected]>
  • Loading branch information
leechor authored Aug 21, 2023
1 parent 1f16401 commit 848c27b
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 13 deletions.
1 change: 0 additions & 1 deletion .github/actions/comment-on-issue
Submodule comment-on-issue deleted from 966bbb
10 changes: 1 addition & 9 deletions .github/workflows/issue-rebot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,4 @@ jobs:
uses: ./.github/actions/translate-on-issue
with:
translate-title: true
translate-body: false

- name: "Comment in issue"
uses: ./.github/actions/comment-on-issue
with:
message: |
Hello @${{ github.event.issue.user.login }}. We totally like your proposal/feedback, welcome to [send us a Pull Request](https://help.github.com/en/articles/creating-a-pull-request) for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the [Pull Request Template](https://github.com/DataLinkDC/dinky/blob/dev/.github/PULL_REQUEST_TEMPLATE.md) here, provide changelog/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!
* In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
GITHUB_TOKEN: ${{ secrets.TOKEN }}
translate-body: false
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
# under the License.


[submodule ".github/actions/comment-on-issue"]
path = .github/actions/comment-on-issue
url = https://github.com/ben-z/actions-comment-on-issue
[submodule ".github/actions/translate-on-issue"]
path = .github/actions/translate-on-issue
url = https://github.com/xingchun-chen/translation-helper
Expand Down
1 change: 1 addition & 0 deletions dinky-web/src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import { default as defaultSettings, default as Settings } from '../config/defau
import { errorConfig } from './requestErrorConfig';
import { getDataByParamsReturnResult } from './services/BusinessCrud';
import { API } from './services/data';
import {API_CONSTANTS} from "@/services/endpoints";

// const isDev = process.env.NODE_ENV === "development";
const loginPath = API_CONSTANTS.LOGIN_PATH;
Expand Down

0 comments on commit 848c27b

Please sign in to comment.