Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs about global_settings and system_log #2531

Merged
merged 1 commit into from
Nov 16, 2023
Merged

docs about global_settings and system_log #2531

merged 1 commit into from
Nov 16, 2023

Conversation

hlwaa
Copy link
Contributor

@hlwaa hlwaa commented Nov 16, 2023

Purpose of the pull request

This pull request adds docs about global_settings and system_log

Brief change log

  • *Add docs about global_settings below system_setting, such as dinky_setting, dolphin_setting,maven_setting, metrics_setting, resource_setting and modify flink_setting and ldap_setting
  • *Add docs about system_log below system_setting

Verify this pull request

This pull request is just about docs and has no code.

@gaoyan1998 gaoyan1998 added the Doc Improvements or additions to documentation label Nov 16, 2023
@gaoyan1998 gaoyan1998 added this to the 1.0.0 milestone Nov 16, 2023
aiwenmo
aiwenmo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 01b2e1e into DataLinkDC:dev Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiwenmo aiwenmo aiwenmo approved these changes

Assignees

@hlwaa hlwaa

Labels
Doc Improvements or additions to documentation
Projects
Dinky Roadmap
Archived in project
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hlwaa @aiwenmo @gaoyan1998