Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve some feature & added flinksql language for editor #2533

Merged
merged 11 commits into from
Nov 16, 2023

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Nov 16, 2023

Purpose of the pull request

Brief change log

flinksql 官方关键词高亮

image

dinky 扩展语法 关键词高亮
image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

zhu-mingye and others added 5 commits November 16, 2023 01:30
# Conflicts:
#	dinky-core/src/main/java/org/dinky/job/JobConfig.java
#	dinky-web/package.json
#	dinky-web/src/components/CustomEditor/languages/flinksql/constants.ts
#	dinky-web/src/components/CustomEditor/languages/flinksql/index.tsx
#	dinky-web/src/components/CustomEditor/languages/flinksql/keyword.ts
#	dinky-web/src/components/CustomEditor/languages/index.tsx
#	dinky-web/src/components/CustomEditor/languages/javalog/index.tsx
#	dinky-web/src/pages/RegCenter/Alert/AlertGroup/service.ts
@Zzm0809 Zzm0809 requested a review from zackyoungh November 16, 2023 10:24
@Zzm0809 Zzm0809 self-assigned this Nov 16, 2023
@Zzm0809 Zzm0809 added Bug Something isn't working Optimization Optimization function labels Nov 16, 2023
@Zzm0809 Zzm0809 added this to the 1.0.0 milestone Nov 16, 2023
zhu-mingye and others added 3 commits November 16, 2023 10:26
# Conflicts:
#	dinky-web/src/components/CustomEditor/languages/flinksql/keyword.ts
@Zzm0809 Zzm0809 changed the title improve some feature improve some feature & added flinksql language for editor Nov 16, 2023
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 44511d4 into DataLinkDC:dev Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Optimization Optimization function
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants