Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve header's button show logical #2552

Merged
merged 8 commits into from
Nov 20, 2023
Merged

improve header's button show logical #2552

merged 8 commits into from
Nov 20, 2023

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Nov 20, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

zhu-mingye and others added 3 commits November 20, 2023 01:09
# Conflicts:
#	dinky-web/src/pages/DataStudio/LeftContainer/Project/index.tsx
@Zzm0809 Zzm0809 added the Optimization Optimization function label Nov 20, 2023
@Zzm0809 Zzm0809 added this to the 1.0.0 milestone Nov 20, 2023
@Zzm0809 Zzm0809 requested a review from zackyoungh November 20, 2023 02:19
@Zzm0809 Zzm0809 self-assigned this Nov 20, 2023
zhu-mingye and others added 5 commits November 20, 2023 02:20
# Conflicts:
#	dinky-web/src/pages/DataStudio/HeaderContainer/index.tsx
#	dinky-web/src/pages/Home/DevOverView/index.tsx
#	dinky-web/src/pages/Home/index.tsx
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit f1a0d15 into DataLinkDC:dev Nov 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants