Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-3764][core] Fix execute failed #3774

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[Fix-3764][core] Fix execute failed #3774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dinky-common/src/main/java/org/dinky/data/enums/Status.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ public enum Status {
MODE_IS_NOT_ALLOW_SELECT(12014, "mode.is.not.allow.select"),
OPERATE_NOT_SUPPORT_QUERY(12015, "operate.not.support.query"),
TASK_NOT_OPERATE_PERMISSION(12016, "task.not.operate.permission"),
TASK_SQL_NO_EXECUTABLE(12017, "task.sql.no.executable"),

/**
* alert instance
Expand Down
1 change: 0 additions & 1 deletion dinky-common/src/main/resources/i18n/messages_en_US.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ task.update.failed=Task Update failed
mode.is.not.allow.select=Application / Pre-Job mode does not allow executing select statements. To perform this operation, please switch to Local, Standalone, or Yarn session modes.
operate.not.support.query=The [Run] button does not support select statements, please switch to the [Query] button.
task.not.operate.permission=No operation permission for the task
task.sql.no.executable=Does not contain executable statement types: {0}

# process
process.submit.submitTask= Submit the job
Expand Down
1 change: 0 additions & 1 deletion dinky-common/src/main/resources/i18n/messages_zh_CN.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ task.update.failed=Task更新失败
mode.is.not.allow.select=Application / Pre-Job 模式不允许执行 select 语句, 如需执行此操作, 请切换至 Local、Standalone、Yarn session等模式
operate.not.support.query=[运行] 按钮不支持 select 语句，请切换至 [查询] 按钮
task.not.operate.permission=任务无操作权限
task.sql.no.executable=不包含可执行的语句类型: {0}

# process
process.submit.submitTask=提交作业
Expand Down
8 changes: 1 addition & 7 deletions dinky-core/src/main/java/org/dinky/job/builder/JobTransBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
import org.dinky.assertion.Asserts;
import org.dinky.constant.FlinkSQLConstant;
import org.dinky.data.enums.GatewayType;
import org.dinky.data.enums.Status;
import org.dinky.data.exception.BusException;
import org.dinky.data.result.IResult;
import org.dinky.data.result.InsertResult;
import org.dinky.data.result.ResultBuilder;
Expand All @@ -44,12 +42,10 @@
import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings;
import org.apache.flink.table.api.TableResult;

import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.UUID;
import java.util.stream.Collectors;

/**
* JobTransBuilder
Expand All @@ -68,9 +64,7 @@ public static JobTransBuilder build(JobManager jobManager) {
@Override
public void run() throws Exception {
if (jobParam.getTrans().isEmpty()) {
String transSqlTypes =
SqlType.getTransSqlTypes().stream().map(SqlType::getType).collect(Collectors.joining(","));
throw new BusException(MessageFormat.format(Status.TASK_SQL_NO_EXECUTABLE.getMessage(), transSqlTypes));
return;
}

if (useStatementSet) {
Expand Down
Loading