Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize][Flink]Optimize DInky without Flink dependency, unable to start, etc #3955

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

zackyoungh
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@zackyoungh zackyoungh added the Optimization Optimization function label Nov 26, 2024
@zackyoungh zackyoungh added this to the 1.2.0 milestone Nov 26, 2024
@zackyoungh zackyoungh self-assigned this Nov 26, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 117e1a6 into dev Nov 26, 2024
34 checks passed
@zackyoungh zackyoungh deleted the optimize_no_flink_deps_no_start_dinky branch November 27, 2024 13:42
MactavishCui pushed a commit to MactavishCui/dinky that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants